Bug in linuxfslib.php causing disk usage not to be counted

[Spacedust]

Mustafa you made a huge mistake in this file. Leaving disk usage count to work only on linux installations using english language only.

[Spacedust]

You disabled this:

Code: [Select]

$rt = lxshell_output("du", "-sc", $path);
$os  = preg_replace("/s+/", ":", $rt);
$ret = explode(":", $os);
$t = $ret[2];

and replaced this with non-working code if Linux installation is installed in different language than English !

Code: [Select]

exec("du -sc {$path} | grep -i 'total'", $out);
$os  = preg_replace("/s+/", ":", $out[0]);
$t = str_replace(":total", "", $os);

Take a look:

Code: [Select]

[root@nowosci /]# du -sc /home/admin
100544  /home/admin
100544  razem

So there is no word total !

Code: [Select]

[root@nowosci /]# du -sc /home/admin | grep total
[root@nowosci /]#

That's why Kloxo isn't counting quota properly on so many systems, because we use polish on all of them !

[Spacedust]

It will be very easy to switch to quotas now - see example:

quota -u monia_mal
Disk quotas for user monia_mal (uid 2117):
 System plików   bloki mi?kki  twardy  pob?.   pliki mi?kki  twardy  pob?.
      /dev/root      28  52428800 52428800              79       0       0
       /dev/md2 33699544  52428800 52428800          312604       0       0

We should just use du -sc for mail and databases and use quota for /home.

This will give us realtime disk usage at least for /home.

[MRatWork]

Look like need modified as:

Code: [Select]

  exec("du -sc {$path} | grep -i '{$path}'", $out);
   $os  = preg_replace("/s+/", ":", $out[0]);
   $t = str_replace(":total", "", $os);

[Spacedust]

Look like need modified as:

Code: [Select]

  exec("du -sc {$path} | grep -i '{$path}'", $out);
   $os  = preg_replace("/s+/", ":", $out[0]);
   $t = str_replace(":total", "", $os);

Yes it works ok on polish linux. But this is only a temporary solution which takes almost 4 hours to count on our filesystem and causing very high I/O load. We must use quota -u as soon as possible.

[MRatWork]

Using 'quota -u' not work in my servers

[Spacedust]

Using 'quota -u' not work in my servers

Make sure you use add "usrjquota=aquota.user,grpjquota=aquota.group,usrquota,grpquota" to each entry you want quotas in /etc/fstab:

Code: [Select]

proc /proc proc defaults 0 0
none /dev/pts devpts gid=5,mode=620 0 0
tmpfs /dev/shm        tmpfs   defaults        0       0
/dev/md0 /boot ext3           defaults  1 1
/dev/md1        /       ext4    rw,discard,noatime,nodiratime,usrjquota=aquota.user,grpjquota=aquota.group,usrquota,grpquota,jqfmt=vfsv0        1       1
/dev/md2        /home   ext4    rw,noatime,nodiratime,usrjquota=aquota.user,grpjquota=aquota.group,usrquota,grpquota,jqfmt=vfsv0        0       0
/dev/md3 /var/lib/mysql ext4    rw,discard,noatime,nodiratime,usrjquota=aquota.user,grpjquota=aquota.group,usrquota,grpquota,jqfmt=vfsv0  1      1
/root/swapfile1 swap swap defaults 0 0
Then reboot to remount all partition.

Then run /script/fixquota and all will work ok.

[MRatWork]

@Spacedust,

A problems is most servers (especially vps) not using quota for partitions. Using 'quota -u' need modified partition config and it's make more difficult rather then using 'du -sc'.

[Spacedust]

@Spacedust,

A problems is most servers (especially vps) not using quota for partitions. Using 'quota -u' need modified partition config and it's make more difficult rather then using 'du -sc'.

All servers should use quotas. What's the problem to add these entries during Kloxo install ?

You can then remount partitions with:

Code: [Select]

remount -o /dev/<partitionname>
No need to reboot. cPanel and DirectAdmin are using quotas so I don't know what's the problem.

If you dislike quotas then please make a second version with du -sc and use it by default. We won't use du -sc because it's overloading our servers.

Imagine what would happens if you run it on a 16 TB array. It would take ages to complete.

If you won't use quotas then your users are able to use more disk space than they're allowed so this is a big security problem.

[Spacedust]

Sorry, a typo:

Code: [Select]

mount -o remount /dev/<partitionname>
Then you should see something like this inside dmesg:

Code: [Select]

EXT4-fs (md1): re-mounted. Opts: discard,usrjquota=aquota.user,grpjquota=aquota.group,usrquota,grpquota,jqfmt=vfsv0

[MRatWork]

Try with:

Code: [Select]

// exec("du -sc {$path} | grep -i '{$path}'", $out);
exec("du -s {$path}", $out);
$os  = preg_replace("/s+/", ":", $out[0]);
$t = str_replace(":{$path}", "", $os);


[Spacedust]

Try with:

Code: [Select]

// exec("du -sc {$path} | grep -i '{$path}'", $out);
exec("du -s {$path}", $out);
$os  = preg_replace("/s+/", ":", $out[0]);
$t = str_replace(":{$path}", "", $os);


Work ok for me, but maybe we should use ionice -c2 before this command to reduce I/O load ?

How these lines should look if I want to use quota ?

[MRatWork]

Yes. this function 'lxfile_dirsize($path, $byteflag = false)' need 'path'.

If using 'quota -u', need new function like 'lxfile_quotasize($user, $byteflag = false)'.

[Spacedust]

Yes. this function 'lxfile_dirsize($path, $byteflag = false)' need 'path'.

If using 'quota -u', need new function like 'lxfile_quotasize($user, $byteflag = false)'.

Can you write one for testing purposes ?

[Spacedust]

Mustafa do something about this. It's overloading our servers !!!

Here's load average from last night: