Sponsor:

Server and Web Integrator
Link:
Kloxo-MR logo
6.5.0 or 7.0.0
Click for "How to install"
Donation/Sponsorship:
Kloxo-MR is open-source.
Donate and or Sponsorship always welcome.
Click to:
Click Here
Please login or register. 2018-11-15, 19:19:52

Author Topic: [CRITICAL] Editing advanced cron reset all values to 0  (Read 7835 times)

0 Members and 1 Guest are viewing this topic.

Offline Spacedust

  • Super Grand Master
  • ****
  • Posts: 3,962
  • Karma: +1/-0
    • View Profile
Bingo ! Kloxo-MR 6.5.1.b-2014041003 works fine :)

Here comes the file: http://tnij.org/7yk3ykq
« Last Edit: 2015-06-10, 00:32:07 by Spacedust »

Offline Spacedust

  • Super Grand Master
  • ****
  • Posts: 3,962
  • Karma: +1/-0
    • View Profile
There is a bug somewhere here:

Quote
   static function convertBackCronList($list, $staticlist)
   {
      if (is_string($list)) {
         $list = array($list);
      }

      foreach ($list as $k => $v) {
         if ($v === '--all--') {
         return $list;
      }


         if ($staticlist) {
            $outl[] = $staticlist[$k];
         } else {
            $outl[] = $k;
         }
      }
      
      return $outl;
   }

Restoring this showed proper values when editing but they are not saved to cron (it also removes all fields in editor) however on cron list they are properly edited, must be something else too:

Quote
   static function convertBackCronList($list, $staticlist)
   {
      if ($list[0] === '--all--') {
         return $list;
      }

      foreach ($list as $l) {
         if ($staticlist) {
            $outl[] = $staticlist[$l];
         } else {
            $outl[] = $l;
         }
      }
      

      return $outl;
   }
« Last Edit: 2015-06-10, 12:35:40 by Spacedust »

Offline Spacedust

  • Super Grand Master
  • ****
  • Posts: 3,962
  • Karma: +1/-0
    • View Profile
Mustafa any ideas ?

Offline Spacedust

  • Super Grand Master
  • ****
  • Posts: 3,962
  • Karma: +1/-0
    • View Profile
It all started when you fixed security bug: https://github.com/mustafaramadhan/kloxo/commit/71d145fcfee7dad378e1c34f26ad8f65e2768f53 editing cron jobs causes all values to be 0
« Last Edit: 2015-06-10, 13:44:51 by Spacedust »

Offline Spacedust

  • Super Grand Master
  • ****
  • Posts: 3,962
  • Karma: +1/-0
    • View Profile
OK - my latest code almost works well. Please note it was translated to Polish, because you still didn't add this to our translation file.

Also static $__desc_weekday = array("", "", "day_of_week"); is a correct form not "Week" which does not exists on our translation file as well.
« Last Edit: 2015-06-10, 14:43:36 by Spacedust »

Offline Spacedust

  • Super Grand Master
  • ****
  • Posts: 3,962
  • Karma: +1/-0
    • View Profile
Still not working well in latest upload.

Please see:


Offline Spacedust

  • Super Grand Master
  • ****
  • Posts: 3,962
  • Karma: +1/-0
    • View Profile
Just tested 7.0.0.b-2015061802 and still doesn't work all values other than 0 are changed to 0 when editing...

Offline Spacedust

  • Super Grand Master
  • ****
  • Posts: 3,962
  • Karma: +1/-0
    • View Profile
Is it fixed ?

Offline MRatWork

  • Administrator
  • The Elite
  • *****
  • Posts: 15,382
  • Karma: +115/-9
  • Gender: Male
    • View Profile
    • MRatWork Forum
Only update still unfixed. But, no issue for add cron.
..:: MRatWork (Mustafa Ramadhan Projects) ::..
-- Server/Web-integrator - Web Hosting (Kloxo-MR READY!) --

Offline Spacedust

  • Super Grand Master
  • ****
  • Posts: 3,962
  • Karma: +1/-0
    • View Profile
Only update still unfixed. But, no issue for add cron.

I do not mean adding. I mean editing - all values are reset to 0 !

Offline MRatWork

  • Administrator
  • The Elite
  • *****
  • Posts: 15,382
  • Karma: +115/-9
  • Gender: Male
    • View Profile
    • MRatWork Forum
Re: [CRITICAL] Editing advanced cron reset all values to 0
« Reply #40 on: 2015-07-04, 22:17:54 »
So, at this moment, delete the old ones and then add the new one.
..:: MRatWork (Mustafa Ramadhan Projects) ::..
-- Server/Web-integrator - Web Hosting (Kloxo-MR READY!) --

Offline Spacedust

  • Super Grand Master
  • ****
  • Posts: 3,962
  • Karma: +1/-0
    • View Profile
Re: [CRITICAL] Editing advanced cron reset all values to 0
« Reply #41 on: 2015-07-05, 00:18:49 »
So, at this moment, delete the old ones and then add the new one.

My code is working fine even when editing ;)

 


Top 4 Global Search Engines:    Google    Bing    Baidu    Yahoo
Click Here

Page created in 0.062 seconds with 23 queries.

web stats analysis